jeanluc

@Ch3LL Just a friendly notice in case you missed it: I believe I have addressed/responded to all your remarks some time ago. Would you mind re-reviewing?

@garethgreenaway Does that imply I will have to close this PR and create a new one against the new repository? I'm honestly not really motivated to once again rebase and...

> Why vault will be moved out of core Salt? This is pretty nice integration and as such I don't see any reason to not be part of the core...

Sorry for dismissing the review, had to resolve conflicts after the `idna` changes.

@dwoz Anything holding this up? It should be quite straight-forward.

I'm also seeing this message, but as mentioned it's only happening as a side effect when a state run fails otherwise. I'm reasonably sure it's caused by: https://github.com/saltstack/salt/blob/daef7613bc359822a4f04ffdd7a91a9edcac7c80/salt/utils/event.py#L823-L829 For fatal...

Yeah, in my mind I had classified this as a rendering error since no states ran. I wouldn't call it informational though, it's failing the requested execution for good. Either...

The Salt master does not not run as root anymore, see the release notes: https://docs.saltproject.io/en/latest/topics/releases/3006.0.html#linux-packaging-salt-master-salt-user-and-group

Pretty sure the right place for general proposals is https://github.com/saltstack/great-module-migration. My comment above was intended to point out we shouldn't rip apart a pair of execution/state module.

@jbartak The traceback shows that you were using a custom `pass` renderer (at `/var/cache/salt/minion/extmods/renderers/pass.py`), which then delegates to the internal one. Do you import and call it directly from your...