Paul Eipper

Results 92 comments of Paul Eipper

Only the ModelType should have model_class property. It's probably a bug in ListType to assume its field has that property https://github.com/schematics/schematics/blob/3a144be0aa50f68a4da917e8d957b924dedf9a52/schematics/types/compound.py#L200

Couldn't you match on the parameters content? ```py from schematics.models import Model from schematics.types import serializable, StringType, IntType, PolyModelType state1 = { 'resource': 'StateType1', 'parameters': { 'x': '1', 'y': '2',...

Can you please test with the 2.1 version?

Thanks, I'll open a review for the pickling issues. It requires tests to make it a reliable feature.

@alexhayes All help is welcome! :)

There's #318 referencing `ModelType.strict` too. Is your case something a DictType is not enough for? Do you have a sample test case?

Thanks for the example. Indeed the strict (and other options) can use more granularity, we just need to find the right way to set it without overburdening the API or...

LGTM. Great work @kstrauser ! Moving to Python 3 is important to keep maintenance manageable, contributions are scarce as it is. @Mizaro is there some existing PR you would request...

Thanks for reporting. Copying here the traceback: ``` Traceback (most recent call last): File "", line 1, in File "", line 2, in Form File "/schematics/schematics/types/base.py", line 399, in __init__...

Why would you like to skip the conversion step? It makes sure the data is in the proper type for validation. If we remove that step we would need to...