brackets-ruler icon indicating copy to clipboard operation
brackets-ruler copied to clipboard

ruler isn't scaling correctly

Open rhbecker opened this issue 10 years ago • 8 comments

I've disabled all extensions except for brackets-ruler. I've reset the theme to the Brackets default. No matter what, the ruler isn't scaled correctly.

The guide displays in the proper place relative to my guidePosition setting, but relative to the ruler, it appears to be in the wrong place. For every 10 columns of actual real estate, the ruler thinks it's 9 columns. So, when I have guidePosition set to 80, the guide appears to be at 72, relative to the ruler.

I'm on ...

  • Release 1.1 build 1.1.0-15558 (release ea908cae5)
  • Windows 7
  • brackets-themes.fontType: "'SourceCodePro-Medium', MS ゴシック, 'MS Gothic', monospace"

ruler

rhbecker avatar Jan 28 '15 19:01 rhbecker

@rhbecker agreed, I have been seeing some scrolling problems recently. I will take a look into it, thanks.

lkcampbell avatar Jan 30 '15 15:01 lkcampbell

@rhbecker, sorry haven't looked at this in a while. Is this issue still a problem for you?

I'm having a difficult time reproducing the problem, probably because I am on a Mac instead of a Windows machine.

From your screenshot, it looks like the tick marks are failing to resize correctly. Can you check out a few things for me?

What size is your font?

Resize the font and see if the tick mark size corrects itself after you do that.

Go into Debug > Show Developer Tools and see if there are any errors.

lkcampbell avatar Feb 28 '15 17:02 lkcampbell

Also, if you happen to be using a development build of Brackets, I would be interested in seeing if you have any failures on the Unit Tests.

If Debug > Run Tests is available, would you mind jumping to the Extensions tab and clicking on the Column Ruler test suite and let me know if it reports any errors? Not including the Gutter Width error which is a known issue I am working to fix today.

If Debug > Run Tests is not available, you aren't on a Developer build, so don't worry about it.

lkcampbell avatar Feb 28 '15 17:02 lkcampbell

@rhbecker, actually, before you try any of that, update the Column Ruler extension to version 2.3.8. Changes I implemented for a couple of other bugs may fix this issue as well.

Let me know either way.

lkcampbell avatar Feb 28 '15 18:02 lkcampbell

@rhbecker, I'm closing as fixed. Reopen if I am incorrect in this assumption.

lkcampbell avatar Mar 02 '15 00:03 lkcampbell

I've updated to 2.3.9 (appears to be the latest) and this issue persists.

I'm not on the developer version of Brackets.

I did try updating Brackets to the latest: Release 1.2 build 1.2.0-15697 (release 8f82e2a97). This update did not change my experience.

With only this ruler extension loaded, I don't get any errors (or even warnings) in the dev tools console.

According to the dev tools inspector, my font size is 12px. If I scale the font up by 3 (hitting Ctrl++ 3 times), the font size becomes 15px and the ruler appears to be properly scaled. When I restore to "normal" font size (Ctrl+0), I get what was in my prior screenshot.

rhbecker avatar Mar 02 '15 19:03 rhbecker

Oh, and as far as I know, I'm not able to reopen an issue you've closed. I assume these replies are sufficient.

rhbecker avatar Mar 02 '15 19:03 rhbecker

@rhbecker, I am rewriting this entire extension and tossing on the ruler interface. It will run completely on preferences very soon. Maintaining it in the face of constant Brackets changes is not working. Stay tuned for version 3.0.

lkcampbell avatar Apr 12 '17 00:04 lkcampbell