cl-png icon indicating copy to clipboard operation
cl-png copied to clipboard

The call to make-array to make-sharable-array on Lispworks in broken.

Open Yehouda opened this issue 3 years ago • 2 comments

https://github.com/ljosa/cl-png/blob/5790e3ec57e27493eb197cbe4ae4d5bd980c567f/image.lisp#L131 It currentll passes the :allocation :static kwyord before the arguments, including the dimensions required argument. That is the wrong syntax, the required argumnet must come first. I fixed it in my copy by chaging to:

(apply #'make-array
         (car args)
	 #+(or lispworks allegro) :allocation
	 #+lispworks :static #+allegro :static-reclaimable
	 (cdr args))

That is working on LispWorks. Probably on Allegro too, but I didn't check.

Found by running the tests of the quicklisp system "dataloader.test".

Yehouda avatar Feb 01 '22 13:02 Yehouda

Good catch! Are you up for putting together a pull request?

ljosa avatar Feb 01 '22 14:02 ljosa

No. I test code that I load by quicklisp, and don;t work on github. I come here (github) only to hassle people.

Yehouda avatar Feb 01 '22 14:02 Yehouda