ljleb

Results 256 comments of ljleb

If you have an image in img2img tab, you can just leave the image in controlnet unit empty. It will seek the img2img image and use it automatically.

One thing that I notice is that default values are duplicated a bunch of places in the code. I'm thinking of putting them in one place and override when needed...

Thanks for your input! Sure I can add a "fetch args from script" function like you implemented earlier. My intention was for users to create and manage their own list...

I agree. Having to pass strings like `"Scale to Fit (Inner Fit)"` as args is very error prone and I heard the issue of i18n being raised. We should use...

I just found why model list is only updated in api between restarts. The `cn_models_names` dict is imported in `api.py` but the value is `= {}` instead of `.clear()` in...

@Mikubill don't really wanna bother you just for this, but just to be sure, is it fine if I create a wiki page for this `external_code` module?

Thanks for the help! If you want, I think you can test now, whenever you find some time. I ran the code a bit and rephrased some of the code...

Thanks for the feedback. > item 1 ~~Sure I didn't run the importlib code, I'll update the wiki.~~ Done. > item 2 Can you try with `external_code.get_models(update=True)`? If the list...

I think I'll add a new function that works directly with `p` instead.

> In fact, I think I'm right here, as I was noticing the later addons breaking with your code... as in 15 args shifted... when they shouldn't have? Can you...