qs icon indicating copy to clipboard operation
qs copied to clipboard

"Cannot read property 'custom' of undefined" in v6.10.x

Open abhinavrastogi-harness opened this issue 3 years ago • 5 comments

I'm getting a JS exception after upgrading to the latest version:

Uncaught TypeError: Cannot read property 'custom' of undefined

yarn.lock entry for my dependency:

qs@^6.9.4:
  version "6.10.1"
  resolved "https://registry.yarnpkg.com/qs/-/qs-6.10.1.tgz#4931482fa8d647a5aab799c5271d2133b981fb6a"
  integrity sha512-M528Hph6wsSVOBiYUnGf+K/7w0hNshs/duGsNXPUCLH5XAqjEtiPGwNONLV0tBH8NoGb0mvD5JubnUTrujKDTg==
  dependencies:
    side-channel "^1.0.4"

Another concern is that the bundle size increased by 30kb (because of qs's new dependency side-channel probably) with this upgrade. This one is not a blocker, but definitely a concern.

abhinavrastogi-harness avatar Mar 26 '21 11:03 abhinavrastogi-harness

What bundler are you using? A couple of them are broken with how they respect the browser field.

The size isn’t a concern; it’s the smallest size that can correctly address the problem it’s solving.

ljharb avatar Mar 26 '21 14:03 ljharb

I faced this issue while bundling using Rollup.

abhinavrastogi-harness avatar Mar 27 '21 09:03 abhinavrastogi-harness

the same question too

little3201 avatar Mar 27 '21 13:03 little3201

If rollup is unable to bundle this package, please file an issue on rollup.

ljharb avatar Mar 29 '21 05:03 ljharb

has any update? it still happened when I use yarn2 & vite to compile it

littlecxm avatar May 24 '22 04:05 littlecxm

any updates here?

Garine519 avatar Jan 04 '23 19:01 Garine519

I believe this remains an issue with specific bundlers.

If there's something actionable here, i'd be happy to reopen.

ljharb avatar Jan 04 '23 20:01 ljharb