qs issue #122

https://github.com/hapijs/qs/issues/122 let me know your'e thoughts, I know remove test cases isn't ideal but I removed the functionality where we make the value the key and the value of that key true.

Oct 19 '15 18:10 MadManMathew

the removal of tests shows that this would be a breaking change. i need to think about this.

Oct 20 '15 16:10 nlf

@MadManMathew If you're still interested in landing this, could you rebase (not merge) on top of latest master?

Feb 02 '16 06:02 ljharb

@ljharb yes will do

Feb 03 '16 17:02 MadManMathew

@ljharb I messed up the rebase, will fix.

Feb 18 '16 00:02 MadManMathew

no worries, just ping me when you'd like me to take a look!

Feb 18 '16 04:02 ljharb

@MadManMathew if you're still interested in landing this, please use my version of your tests (from https://github.com/ljharb/qs/commit/75fe7ce14f65de58ad3665d5d541208c07b3c014) and let's get it working without removing any existing tests. Changing them slightly may end up being fine.

Jul 21 '16 05:07 ljharb

@MadManMathew if you're not interested in completing this PR, would you mind checking the "allow edits" checkbox on the right hand column?

May 20 '17 05:05 ljharb

@ljharb sorry will do

May 29 '17 19:05 MadManMathew

I've rebased this and included my tests; but I'm not sure how to adapt your fix to make the tests pass.

May 30 '17 07:05 ljharb

@MadManMathew are you interested in pursuing this PR?

Nov 24 '18 02:11 ljharb