can-merge icon indicating copy to clipboard operation
can-merge copied to clipboard

Fix : Commit statuses from forks are not included

Open PriyaBihani opened this issue 3 years ago • 3 comments

can-merge was not fetching the commit statuses from forks, this PR addresses the issue. There's no way in the github API that allows us to get those checks, only way to get the commit checks of a commit is by providing the original owner of the commit and then running the repository/search query.

As discussed with @ljharb I started by modifying the buildQUery so that it return us the original author of the commit along with the commits. In the runQuery.js i've added a new query that basically is similar to the repo query that we already use, and it calls the github api with the actual author of the commit, which returns us the commit checks. I then merge the two checks.

I've added this modification to just the search query for now, and can update it to work for the repo query as well after the reviews.🙂

PriyaBihani avatar Feb 27 '22 19:02 PriyaBihani

I've rebased this after the latest merges.

ljharb avatar Mar 21 '22 05:03 ljharb

The fork is deleted, so this and #72 are unrecoverable. I'll keep these open in case someone can resurrect anything out of it.

ljharb avatar Apr 26 '22 04:04 ljharb

yay, turns out the fork was just private! i'll rebase this once "allow edits" is re-checked

update: it seems likely that the act of making this repo public severed the connection to all PRs from forks, which means they're indeed unrecoverable :-(

ljharb avatar Apr 26 '22 17:04 ljharb