ljedrz

Results 241 comments of ljedrz

Confirmed to be reproducible in snarkVM; the following test fails: ``` #[test] fn test_sub_overflow() { let mut cs = TestConstraintSystem::::new(); let a: i8 = -1; let b: i8 = -128;...

I know the underlying cause now, I'll take a stab at fixing it :+1:.

The CI error is unrelated: ``` running 1 test test helpers::block_requests::tests::test_block_requests_case_2cbb ... FAILED failures: ---- helpers::block_requests::tests::test_block_requests_case_2cbb stdout ---- thread 'helpers::block_requests::tests::test_block_requests_case_2cbb' panicked at 'assertion failed: `(left == right)` left: `AbortAndDisconnect(TwoCBA, "exceeded...

There's a reason why I proposed this functionality to be opt-in rather than being automatic; if for whatever reason someone is changing their listening port on a regular basic, or...

I've noticed this as well when `cargo update` caused the lockfile to balloon more than I expected; it was caused by one of the indirect dependencies having introduced a `[target.'cfg(target_os...

@lopopolo indeed, it's that dependency; however, since I'm not building on an applicable target, I'd expect it to not show up in my lockfile just as much as if it...

The `compiler` job failure seems transient, but the `clippy` one isn't.

> I saw that the clippy warning was added in another PR. If it was caused by a different change, I think it should be a separate PR, so it...