Yinan Li

Results 46 comments of Yinan Li

@kalvinnchau are you still interested in working on this?

Please update the chart version.

Please bump up the chart version as defined in https://github.com/GoogleCloudPlatform/spark-on-k8s-operator/blob/master/charts/spark-operator-chart/Chart.yaml, given that you modified the chart yamls.

The changes look good to me. However, looks like a few integration tests failed. Can you fix them?

Looks like you also need to bump the chart version.

Seems related to https://github.com/GoogleCloudPlatform/spark-on-k8s-operator/issues/1056.

@aditanase sorry for not responding sooner. I think that's a viable approach. And yes the admission webhook can be used to inject an init-container for doing that. Thanks for being...

The pod template support will make the webhook obsolete for users using Spark 3.0 (assuming that's the version in which the PR will get into). For users who use Spark...

The approach proposed above of using an init-container to copy the files in `sparkConfigMap` to `$SPARK_CONF_DIR` of the main Spark container seems reasonable. This can be setup automatically by the...

@wweic how about patching the internally created ConfigMap to append data stored in the user-specified ConfigMap (defined in `sparkConfigMap`)? We can easily find the internally created ConfigMap because it has...