Rainie Li
Rainie Li
> I am not sure which PR is the one you are working on. The email pointed back to this PR: config validation code for the resources of a queue...
> > updated, please review.
> I have some concerns regarding some pieces of the code, please take a look at those, thanks. Thanks for reviewing the code. I have updated them and addressed all...
Hi @manirajv06 Can you take a look? I saw @wilfred-s requested a review from you 11 days ago.
> Thanks @craigcondit for reviewing the PR. I addressed your comments about combining the methods. _canRun_ code is outdate, please review _incAllocatingAcceptedAppsIfCanRun_ method
> Thank you @craigcondit. I addressed comments. @wilfred-s @pbacsko please take a look when you have time, thanks!
> @lixmgl / @pbacsko / @manirajv06 / @craigcondit Please check PR #455. I ported the changes to master and moved the logic into the queue code. I added unit tests...
> > Can we merge this PR to master first then add your PR? > > This PR formed the basis under my port. We can merge the ported PR...
> Hi. Is there any further progress by any chance? I'm waiting as this feature is very useful and needed. hi @chia7712 are you still actively working on this ticket?...
> @lixmgl feel free to take over it. thanks :) Will do :)