protocol icon indicating copy to clipboard operation
protocol copied to clipboard

Ensure the treasury automatically resumes once balance < cap

Open stronk-dev opened this issue 9 months ago • 1 comments

What does this pull request do? Explain your changes. (required) Ensures the treasury automatically resumes instead of setting the cut to 0% once the cap is reached. This way, it will continue accumulating as the balance depletes.

Wondering if this can be a good solution instead of raising the cap. Note that this will cause an emitted ParameterUpdate event for the treasuryRewardCutRate after each round it flips below/above the cap. This change does not affect the subgraph, as that is not updated to take the treasury into account at all at the moment.

Specific updates (required)

  • Removes logic in reward calls which modifies nextRoundTreasuryRewardCutRate when the cap is reached.
  • Modify Round init to set the cut for the current round only to 0 for as long as the cap is reached.

How did you test each of these updates (required) N/A

Does this pull request close any open issues? N/A

Checklist:

  • [ ] README and other documentation updated
  • [ ] All tests using yarn test pass

stronk-dev avatar Apr 02 '25 14:04 stronk-dev

Tests need updating for this as well.

stronk-dev avatar Apr 02 '25 14:04 stronk-dev