Use the same SegmentInfo for default and for probing
Follow-up PR to https://github.com/livepeer/go-livepeer/pull/3532
Otherwise the first probed segment may be different for G and O and it may cause some inconsistencies.
Codecov Report
Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.
Project coverage is 31.71665%. Comparing base (
59c435d) to head (659f540). Report is 1 commits behind head on master.
| Files with missing lines | Patch % | Lines |
|---|---|---|
| server/live_payment_processor.go | 0.00000% | 2 Missing :warning: |
Additional details and impacted files
@@ Coverage Diff @@
## master #3656 +/- ##
===================================================
+ Coverage 31.70484% 31.71665% +0.01181%
===================================================
Files 156 156
Lines 47283 47278 -5
===================================================
+ Hits 14991 14995 +4
+ Misses 31407 31399 -8
+ Partials 885 884 -1
| Files with missing lines | Coverage Δ | |
|---|---|---|
| server/live_payment_processor.go | 0.00000% <0.00000%> (ø) |
... and 3 files with indirect coverage changes
Continue to review full report in Codecov by Sentry.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing dataPowered by Codecov. Last update 59c435d...659f540. Read the comment docs.
| Files with missing lines | Coverage Δ | |
|---|---|---|
| server/live_payment_processor.go | 0.00000% <0.00000%> (ø) |
:rocket: New features to boost your workflow:
- :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
The PR looks fine but a little confused about why we need it, since I thought we were doing time based payments now instead of pixel based
The PR looks fine but a little confused about why we need it, since I thought we were doing time based payments now instead of pixel based
Well... it's "time-based", but we still account in pixels. In other words, we use the same segment details everywhere, which makes it time-based.