go-livepeer icon indicating copy to clipboard operation
go-livepeer copied to clipboard

Rename "capacity" to "count" in the aiModels.json

Open leszko opened this issue 8 months ago • 3 comments

@ad-astra-video please check if it works for the AI Jobs.

This change is non-backward-compatible, but there are only 3 Os using it right now, so we can handle.

The context for this change is this GH Issue: https://github.com/livepeer/go-livepeer/issues/3627

FYI: @pwilczynskiclearcode (but from what I see we haven't used "capacity" in our infra, so it should be fine) FYI: @victorges

leszko avatar Jun 23 '25 09:06 leszko

Codecov Report

Attention: Patch coverage is 0% with 7 lines in your changes missing coverage. Please review.

Project coverage is 31.70737%. Comparing base (dab7dad) to head (f44d34c).

Files with missing lines Patch % Lines
cmd/livepeer/starter/starter.go 0.00000% 7 Missing :warning:
Additional details and impacted files

Impacted file tree graph

@@                 Coverage Diff                 @@
##              master       #3639         +/-   ##
===================================================
+ Coverage   31.69613%   31.70737%   +0.01124%     
===================================================
  Files            156         156                 
  Lines          47296       47295          -1     
===================================================
+ Hits           14991       14996          +5     
+ Misses         31420       31415          -5     
+ Partials         885         884          -1     
Files with missing lines Coverage Δ
core/ai.go 67.40741% <ø> (ø)
cmd/livepeer/starter/starter.go 7.28597% <0.00000%> (+0.00442%) :arrow_up:

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update dab7dad...f44d34c. Read the comment docs.

Files with missing lines Coverage Δ
core/ai.go 67.40741% <ø> (ø)
cmd/livepeer/starter/starter.go 7.28597% <0.00000%> (+0.00442%) :arrow_up:

... and 2 files with indirect coverage changes

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov[bot] avatar Jun 23 '25 09:06 codecov[bot]

@leszko I was able to startup my LLM runner with "capacity": 3 using managed containers. Thanks for getting this PR sent!

ad-astra-video avatar Jun 26 '25 11:06 ad-astra-video

@ad-astra-video Updated with your suggestions. PTAL.

leszko avatar Jul 15 '25 13:07 leszko