go-livepeer icon indicating copy to clipboard operation
go-livepeer copied to clipboard

update base ubuntu image in Dockerfile

Open ad-astra-video opened this issue 9 months ago • 4 comments

What does this pull request do? Explain your changes. (required)

Update go-livepeer to use ubuntu 22.04 in base image. Ubuntu 22.04 security maintenance expires in April 2027.

I tested on my test gateway and locally noting no issues but more testing should be done.

Should we bump to cuda 12.8 to add Blackwell support? There is no need transcoding related for Blackwell support yet.

Note minimum driver requirements: image

Specific updates (required)

  • updated Dockerfile and Dockerfile.base
  • added regular cuda path to CPATH, LIBRARY_PATH and CGO_LDFLAGS to enable building without the livepeerci version of the base image

How did you test each of these updates (required)

Does this pull request close any open issues?

Checklist:

  • [ ] Read the contribution guide
  • [X] make runs successfully
  • [X] All tests in ./test.sh pass
  • [ ] README and other documentation updated
  • [ ] Pending changelog updated

ad-astra-video avatar May 30 '25 10:05 ad-astra-video

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 30.76671%. Comparing base (55dcd83) to head (5cad9df).

Additional details and impacted files

Impacted file tree graph

@@                 Coverage Diff                 @@
##              master       #3600         +/-   ##
===================================================
+ Coverage   30.76453%   30.76671%   +0.00218%     
===================================================
  Files            153         153                 
  Lines          45832       45832                 
===================================================
+ Hits           14100       14101          +1     
+ Misses         30911       30910          -1     
  Partials         821         821                 

see 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 55dcd83...5cad9df. Read the comment docs.

see 1 file with indirect coverage changes

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov[bot] avatar May 30 '25 10:05 codecov[bot]

Fine with me, but I see the CI build is failing.

leszko avatar May 30 '25 12:05 leszko

How is the livepeerci/cuda:12.6.3-cudnn-devel-ubuntu22.04 created? I updated the Dockerfile.cuda-base but it does not seem to be creating it?

ad-astra-video avatar May 30 '25 16:05 ad-astra-video

How is the livepeerci/cuda:12.6.3-cudnn-devel-ubuntu22.04 created? I updated the Dockerfile.cuda-base but it does not seem to be creating it?

This is the instruction: https://github.com/livepeer/go-livepeer/blob/280ea4dfe321143b83d51aafaa59adfdc27f0d76/docker/Dockerfile.cuda-base#L1

Do you have access to push into Docker Hub livepeerci? If not, I can build and push the new image. Let me know

leszko avatar Jun 02 '25 07:06 leszko