go-livepeer icon indicating copy to clipboard operation
go-livepeer copied to clipboard

Scaffolding for realtime-to-realtime

Open j0sh opened this issue 1 year ago • 2 comments

What does this pull request do? Explain your changes. (required)

Initial bits of the "live-video-to-video" pipeline (better name welcome)

Depends on https://github.com/livepeer/ai-worker/pull/229 for the realtime schema

Adds a MediaMTX handler for the gateway

Adds realtime-to-realtime capability to the orchestrator

Adds selection support between G/O

Orchestrator will respond to the job with trickle endpoints (publish, subscribe)

j0sh avatar Oct 17 '24 09:10 j0sh

Rebased + force pushed to resolve merge conflicts with the latest ai-video. Opening this PR up for real so we can hopefully merge and build on top of it as a team to minimize further conflicts

j0sh avatar Oct 21 '24 19:10 j0sh

Hey @j0sh, just a heads up—I had to update the dependencies to ensure the network is compatible with the new Go version and other updated libraries. I found a combination that works, but if you need to use lower versions that are also compatible, feel free to adjust them. I'm flexible with it. I'm also improving the code through small pull requests so that it doesn't cause to many conflicts. If you run into problems or need me to rebase just ping me.

rickstaa avatar Oct 23 '24 14:10 rickstaa

Force pushed to fix up a bunch of merge conflicts with the latest ai-video branch

Also squashed everything down to 1 commit to avoid a cascading series of merge conflicts

Builds for this PR are broken for now until the pipeline on the worker / runner side is in, either in https://github.com/livepeer/ai-worker/pull/229 or https://github.com/livepeer/ai-worker/pull/233

j0sh avatar Oct 24 '24 06:10 j0sh

Updated to remove the dependency on AI Worker changes. The scaffolding that is there now is now even less useful, but there is still the capability definition and pipeline path, both of which have caused merge conflicts recently as we've added new stuff

If CI is green here, I'll go ahead and merge so it's easier to stay on the leading edge of the tree.

j0sh avatar Oct 25 '24 22:10 j0sh

Codecov Report

Attention: Patch coverage is 7.27273% with 51 lines in your changes missing coverage. Please review.

Project coverage is 35.87705%. Comparing base (c41f3c4) to head (4733f05). Report is 10 commits behind head on ai-video.

Files with missing lines Patch % Lines
server/ai_http.go 0.00000% 25 Missing :warning:
server/ai_mediaserver.go 19.04762% 16 Missing and 1 partial :warning:
server/ai_process.go 0.00000% 9 Missing :warning:
Additional details and impacted files

Impacted file tree graph

@@                 Coverage Diff                 @@
##            ai-video       #3210         +/-   ##
===================================================
- Coverage   36.07820%   35.87705%   -0.20115%     
===================================================
  Files            124         124                 
  Lines          34525       34713        +188     
===================================================
- Hits           12456       12454          -2     
- Misses         21381       21570        +189     
- Partials         688         689          +1     
Files with missing lines Coverage Δ
core/capabilities.go 81.69336% <ø> (+0.04198%) :arrow_up:
server/ai_process.go 0.00000% <0.00000%> (ø)
server/ai_mediaserver.go 10.99656% <19.04762%> (+0.95939%) :arrow_up:
server/ai_http.go 9.90099% <0.00000%> (-1.16912%) :arrow_down:

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 1bc4a6a...4733f05. Read the comment docs.

Files with missing lines Coverage Δ
core/capabilities.go 81.69336% <ø> (+0.04198%) :arrow_up:
server/ai_process.go 0.00000% <0.00000%> (ø)
server/ai_mediaserver.go 10.99656% <19.04762%> (+0.95939%) :arrow_up:
server/ai_http.go 9.90099% <0.00000%> (-1.16912%) :arrow_down:

... and 1 file with indirect coverage changes

codecov[bot] avatar Oct 25 '24 22:10 codecov[bot]