go-livepeer icon indicating copy to clipboard operation
go-livepeer copied to clipboard

ci: add protoc on build

Open iameli-streams opened this issue 2 years ago • 2 comments

So... this shouldn't be necessary. protoc is needed to build the files in net like net/lp_rpc.pb.go. Those files are committed to the repo; make shouldn't be rebuilding them. And yet, every so often, we get an error on build that looks like this:

protoc -I=. --go_out=plugins=grpc:. net/lp_rpc.proto
/bin/bash: line 1: protoc: command not found
make: *** [Makefile:7: net/lp_rpc.pb.go] Error 127
Error: Process completed with exit code 2.

I don't know why that happens. It doesn't happen once you rebuild. But... regenerating those files is harmless, I guess, so this will stop that for everybody forever. IDK.

iameli-streams avatar Oct 24 '23 21:10 iameli-streams

@iameli shall we merge this?

thomshutt avatar Dec 12 '23 19:12 thomshutt

@thomshutt Let me rebase, but I seem to recall this not solving the problem it was supposed to

iameli avatar Dec 12 '23 21:12 iameli