go-livepeer icon indicating copy to clipboard operation
go-livepeer copied to clipboard
verified publisher icon livepeer

Use fuzzy pixel matching in local verification

Open cyberj0g opened this issue 3 years ago • 5 comments

What does this pull request do? Explain your changes. (required)

Fix for: https://github.com/livepeer/go-livepeer/issues/2649

Specific updates (required) This PR is mostly refactoring and adding some fields to support corresponding LPMS changes: https://github.com/livepeer/lpms/pull/366

How did you test each of these updates (required) Tests are updated.

Does this pull request close any open issues? #2649

Edit: originally wrong corresponding LPMS PR was mentioned

cyberj0g avatar Jan 27 '23 09:01 cyberj0g

@thomshutt please arrange reviewing this and https://github.com/livepeer/lpms/pull/366 to enable local verification. Currently, it's too trivial to build an orchestrator, which would bypass doing any work without suspension, while performing DoS on the streams it serves.

cyberj0g avatar Feb 27 '23 14:02 cyberj0g

Hey @cyberj0g, it looks like the build is still failing here

thomshutt avatar Mar 03 '23 12:03 thomshutt

@thomshutt it will not work, until lpms PR is merged

cyberj0g avatar Mar 03 '23 12:03 cyberj0g

@cyberj0g Oof, gotcha. Looks like the LPMS build is broken too for that PR, so we'll have to try and figure out what's going on there first

thomshutt avatar Mar 03 '23 13:03 thomshutt

@thomshutt I mean this one, not Alex's wrongly mentioned in description: https://github.com/livepeer/lpms/pull/366 It looks good for me.

cyberj0g avatar Mar 03 '23 13:03 cyberj0g