go-livepeer icon indicating copy to clipboard operation
go-livepeer copied to clipboard

livepeer_cli: Fix the "ERROR: logging before flag.Parse" warning when any option is selected

Open emranemran opened this issue 3 years ago • 1 comments

As part of commit 78789b192 (Issue #928), the call to flag.Parse() was commented out perhaps unintentionally. This call is required prior to using glog calls as noted here: https://github.com/golang/glog/blob/master/glog.go#L40

What does this pull request do? Explain your changes. (required)

  • (see above commit desc)

Specific updates (required)

  • (see above commit desc)

How did you test each of these updates (required)

  • Tested locally by invoking livepeer_cli and verifying the erroneous warning is suppressed.

Does this pull request close any open issues? Fix #2186

Checklist:

  • [X] Read the contribution guide
  • [X] make runs successfully
  • [X] All tests in ./test.sh pass
  • [X] README and other documentation updated
  • [X] Pending changelog updated

emranemran avatar Jun 03 '22 20:06 emranemran

Codecov Report

Merging #2445 (d9f4af8) into master (d360781) will not change coverage. The diff coverage is 0.00000%.

Impacted file tree graph

@@              Coverage Diff              @@
##              master       #2445   +/-   ##
=============================================
  Coverage   55.02775%   55.02775%           
=============================================
  Files             94          94           
  Lines          19641       19641           
=============================================
  Hits           10808       10808           
  Misses          8236        8236           
  Partials         597         597           
Impacted Files Coverage Δ
cmd/livepeer_cli/livepeer_cli.go 0.00000% <0.00000%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d360781...d9f4af8. Read the comment docs.

codecov[bot] avatar Jun 04 '22 00:06 codecov[bot]

Ask @emranemran to merge this item.

Quintendos avatar Jan 09 '23 14:01 Quintendos