sip
sip copied to clipboard
livekit
Rejecting inbound flood
Starting SIP server sip --config=config.yaml
Everything was working great .
Now suddenly getting
DEBUG sip sip/inbound.go:429 Rejecting inbound flood {"nodeID": "NE_5LFaTYmsatTj", "callID": "SCL_9BZYVhVbWg8s", "fromIP": "xxxxxxx"
I tried allow specific IP , also all IPs still same result .
Is there a bug or something missing ? Also creating new SipTrunkID returning same result
I have made type in Dispatch rule with number and that was cause me issues . But I figure out that you have typo in docs
https://docs.livekit.io/sip/api/#createsipdispatchrule
inbound_numbers array
If set, the dispatch rule only accepts calls made to numbers in the list. - is misleading instate of to numbers is should be from numbers
Please update
From If set, the dispatch rule only accepts calls made to numbers in the list.
To If set, the dispatch rule only accepts calls made from numbers in the list.
Is it a typo in the docs or inbound_numbers should actually filter by the callee number?
In https://github.com/livekit/protocol/blob/f44a41e4fd30e487f3e4dd94044104db9f48a7d3/sip/sip.go#L733 The check is on the CallingNumber. Shouldn’t be on the CalledNumber? If we assume the documentation is correct.
I have opened a pull request for trying to fix this (livekit/protocol#1162) but the tests are failing. I am not sure which is the expected behaviour, if the one from the documentation or the one from the current implementation.
Thank you all for raising this issue. The check is for "from numbers" here -> https://github.com/livekit/protocol/blob/main/sip/sip.go#L733 . The filter for called numbers happens at the Trunk level. So that PR though very appreciated @arpesenti is not needed. We've gone ahead and updated the docs. I'm going to go ahead and close this.
@nishadmusthafa Was the documentation updated?
I still see the confusing message in LiveKit cloud
The current behavior is that the dispatch rule with inboundNumbers matches only calls made FROM numbers in the list.
Hey @yaniv-peretz , yupp, we did update the docs.
That doesn't sound right. @rektdeckard , would you be able to help fix that in Livekit Cloud ?