client-sdk-swift icon indicating copy to clipboard operation
client-sdk-swift copied to clipboard

Add video pausing option on VideoView

Open VatamanuBogdan opened this issue 1 year ago • 4 comments

I added a video pausing option on VideoView to facilitate complex animation synchronization on the client side.

VatamanuBogdan avatar Aug 28 '24 14:08 VatamanuBogdan

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Aug 28 '24 14:08 CLAassistant

Hi, thanks for your contribution. I think I put isEnabled for this purpose of pausing rendering. Doesn't it work well for you ? Screenshot 2024-08-29 14 04 48

Instead of adding more properties, it would be great if you can optimize the logic of existing isEnabled property.

hiroshihorie avatar Aug 29 '24 05:08 hiroshihorie

Hi, thank you for the response. I tried to use isEnabled but when it's false the VideoView becomes transparent instead of pausing on the last frame. If it's ok for you I can move the pausing logic I wrote to isEnabled to stop the VideoView on the last frame when it's false and to continue the rendering when it's true.

VatamanuBogdan avatar Aug 29 '24 08:08 VatamanuBogdan

Hi, thank you for the response. I tried to use isEnabled but when it's false the VideoView becomes transparent instead of pausing on the last frame. If it's ok for you I can move the pausing logic I wrote to isEnabled to stop the VideoView on the last frame when it's false and to continue the rendering when it's true.

Hi, @hiroshihorie, what do you think?

adrian-niculescu avatar Sep 25 '24 18:09 adrian-niculescu

@VatamanuBogdan let's try to unblock/update this PR, isEnabled + stop sounds fine 👍

pblazej avatar Aug 08 '25 10:08 pblazej