client-sdk-js icon indicating copy to clipboard operation
client-sdk-js copied to clipboard

Add vp9 support for E2EE

Open lukasIO opened this issue 2 years ago • 6 comments

Unfortunately av1 fails with TypeError: Destination stream closed when trying to decode frames. This needs further investigation. Until then, VP9 addition is nice, too!

Caveats: this is currently only secure if backupCodec: undefined is specified. Backup codecs are currently sent unencrypted, which is definitely unexpected.

lukasIO avatar Aug 14 '23 15:08 lukasIO

🦋 Changeset detected

Latest commit: 708003f9695db37b24581e91f895121888a265d2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
livekit-client Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

changeset-bot[bot] avatar Aug 14 '23 15:08 changeset-bot[bot]

size-limit report 📦

Path Size
dist/livekit-client.esm.mjs 80.24 KB (0%)
dist/livekit-client.umd.js 86.06 KB (0%)

github-actions[bot] avatar Aug 14 '23 15:08 github-actions[bot]

closing for now due to the backupCodec complications

lukasIO avatar Aug 15 '23 07:08 lukasIO

@lukasIO

Could you elaborate a little bit?

I'd still consider this open, as VP9 support is still wanted and missing.

Stogas avatar Jul 02 '24 06:07 Stogas

hi @Stogas,

encryption support for backup codecs is missing, which would be needed to ensure that also clients that don't support vp9 would be able to receive the media stream.

I can reopen the issue, but there's currently no ETA for encryption support of backup codecs

lukasIO avatar Jul 04 '24 13:07 lukasIO

We should disable backupCodec when e2ee is used. since vp9 is supported everywhere, I think the impact of that should be fairly minimal

davidzhao avatar Jul 04 '24 18:07 davidzhao

We should disable backupCodec when e2ee is used.

That's what we do already today. I'll update this PR in order to merge it in

lukasIO avatar Jul 05 '24 08:07 lukasIO