client-sdk-js icon indicating copy to clipboard operation
client-sdk-js copied to clipboard

chore: output esm as modules

Open ryanleecode opened this issue 1 year ago • 2 comments

We can output ESM as modules instead of one big file. Should help with https://github.com/livekit/client-sdk-js/issues/1273

ryanleecode avatar Oct 06 '24 15:10 ryanleecode

⚠️ No Changeset found

Latest commit: c249fa774353658659dda08be0d99d3a589f9d7c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

changeset-bot[bot] avatar Oct 06 '24 15:10 changeset-bot[bot]

appreciate the PR, have you done any benchmarks comparing the file sizes of tree shaking imports with/without single file output?

lukasIO avatar Oct 07 '24 08:10 lukasIO

closing due to inactivity

lukasIO avatar Dec 10 '24 09:12 lukasIO