client-sdk-flutter icon indicating copy to clipboard operation
client-sdk-flutter copied to clipboard

flutter web - false positive error message when calling room?.localParticipant?.setMicrophoneEnabled(false)

Open WillComesBack opened this issue 2 years ago • 4 comments

I get this error message in the debug logs everytime i setMicrophoneEnabled(false). The function works, but the error message is a false positive. We should still handle it though. My suggestion could be to put a try/catch on this part, but you can choose to close this and leave it alone if you think it's wrong \pub.dartlang.org\livekit_client-1.1.11\lib\src\participant\local.dart await track.sender?.setTrack(null);

TypeError: o[method] is not a function C:/b/s/w/ir/cache/builder/src/out/host_debug/dart-sdk/lib/_internal/js_shared/lib/js_util_patch.dart 105:57 _callMethodUnchecked1 packages/dart_webrtc/src/rtc_rtp_sender_impl.dart 43:16 setTrack C:/b/s/w/ir/cache/builder/src/out/host_debug/dart-sdk/lib/_internal/js_dev_runtime/patch/async_patch.dart 84:54 runBody C:/b/s/w/ir/cache/builder/src/out/host_debug/dart-sdk/lib/_internal/js_dev_runtime/patch/async_patch.dart 123:5 _async packages/dart_webrtc/src/rtc_rtp_sender_impl.dart 36:24 setTrack packages/livekit_client/src/participant/local.dart 330:33 setSourceEnabled C:/b/s/w/ir/cache/builder/src/out/host_debug/dart-sdk/lib/_internal/js_dev_runtime/patch/async_patch.dart 45:50 C:/b/s/w/ir/cache/builder/src/out/host_debug/dart-sdk/lib/async/zone.dart 1653:54 runUnary C:/b/s/w/ir/cache/builder/src/out/host_debug/dart-sdk/lib/async/future_impl.dart 147:18 handleValue C:/b/s/w/ir/cache/builder/src/out/host_debug/dart-sdk/lib/async/future_impl.dart 766:44 handleValueCallback C:/b/s/w/ir/cache/builder/src/out/host_debug/dart-sdk/lib/async/future_impl.dart 795:13 _propagateToListeners C:/b/s/w/ir/cache/builder/src/out/host_debug/dart-sdk/lib/async/future_impl.dart 566:5 [_completeWithValue] C:/b/s/w/ir/cache/builder/src/out/host_debug/dart-sdk/lib/async/future_impl.dart 639:7 callback C:/b/s/w/ir/cache/builder/src/out/host_debug/dart-sdk/lib/async/schedule_microtask.dart 40:11 _microtaskLoop C:/b/s/w/ir/cache/builder/src/out/host_debug/dart-sdk/lib/async/schedule_microtask.dart 49:5 _startMicrotaskLoop C:/b/s/w/ir/cache/builder/src/out/host_debug/dart-sdk/lib/_internal/js_dev_runtime/patch/async_patch.dart 166:15

WillComesBack avatar Dec 17 '22 16:12 WillComesBack

Which browser are you seeing this with?

davidzhao avatar Feb 15 '23 01:02 davidzhao

Chrome Version 109.0.5414.120 (Official Build) (64-bit)

WillComesBack avatar Feb 15 '23 05:02 WillComesBack

I'm not seeing this with the latest version on Chrome. I think this is likely a bug that's already been fixed. Are you able to repro with 1.1.12?

davidzhao avatar Feb 16 '23 01:02 davidzhao

It says I have the most up to date. It's fine though, I can just surround the error with a try/catch to bypass it. It's not a real big issue [image: image.png]

-Will

On Wed, Feb 15, 2023 at 8:48 PM David Zhao @.***> wrote:

I'm not seeing this with the latest version on Chrome. I think this is likely a bug that's already been fixed. Are you able to repro with 1.1.12?

— Reply to this email directly, view it on GitHub https://github.com/livekit/client-sdk-flutter/issues/224#issuecomment-1432352892, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAJDAVFE7CK2DQPW4MHSEPLWXWBQDANCNFSM6AAAAAATCATN7M . You are receiving this because you authored the thread.Message ID: @.***>

WillComesBack avatar Feb 16 '23 16:02 WillComesBack