agents icon indicating copy to clipboard operation
agents copied to clipboard

Add wait_for_participant to mma example

Open bcherry opened this issue 1 year ago • 4 comments

This was already in other VPA examples but missing here. It's not always necessary but improves reliability (e.g. SIP) and seems worth having in the default case.

bcherry avatar Oct 07 '24 18:10 bcherry

⚠️ No Changeset found

Latest commit: c77ab3aeefa566f8a7406167dd5182385e4924ed

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

changeset-bot[bot] avatar Oct 07 '24 18:10 changeset-bot[bot]

Hey for VPA it is already handled internally. I think we should do the same for MMA

theomonnom avatar Oct 07 '24 19:10 theomonnom

It is already the case actually: https://github.com/livekit/agents/blob/5fedcfdfce510ce96d34d85b38807f0d03389bfc/livekit-agents/livekit/agents/multimodal/multimodal_agent.py#L232

theomonnom avatar Oct 07 '24 19:10 theomonnom

@theomonnom yeah but still all the VPA examples have a wfp in them - is it really unnecessary?

this could be indicative of some sort of bug with how it's set up - it does seem like that should basically work (although it doesn't wait for subscription from the linked_participant but rather from any participant). and someone in community reported that SIP didn't work til they added this. might be worth digging into, I agree it feels unnecessary and it would be good to simplify it away in all of the examples.

bcherry avatar Oct 07 '24 19:10 bcherry

Seems like wait_for_participant was already added by dz in some previous PRs (inside the example/multimodal_agent)

theomonnom avatar Oct 14 '24 20:10 theomonnom