meet icon indicating copy to clipboard operation
meet copied to clipboard

feat: add PTT, keyboard shortcut engine, persistent auxiliary settings

Open rektdeckard opened this issue 7 months ago • 6 comments

  • Adds Push-To-Talk, mappable to Spacebar, Left Mouse, or Middle Mouse
  • Adds an extensible keybinding system we could use for other things in the future
  • Adds persistent storage for auxiliary user settings, akin to usePersistentUserChoices but for application-specific configuration that is outside the purview of the core components

https://www.loom.com/share/38663b9d369a43e4b73b4747c9c075cd

rektdeckard avatar May 23 '25 00:05 rektdeckard

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
meet-production ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 23, 2025 4:22pm
meet-staging ❌ Failed (Inspect) May 23, 2025 4:22pm
sandbox-meet ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 23, 2025 4:22pm

vercel[bot] avatar May 23 '25 00:05 vercel[bot]

what's the idea behind customisable keyboard shortcuts, have users asked for this? 👀

lukasIO avatar May 23 '25 06:05 lukasIO

It'd be great to get the design team involved here just on the button positioning/experience.. Ideally something like

  • Create a Summon Agent button in meet, to dispatch an agent (our version)
  • once summoned, we can push to talk with an agent. so in a meeting, the agent will be passively listening.. and you push a button and it'll engage

davidzhao avatar May 23 '25 06:05 davidzhao

some references for previous PTT ideas/drafts

  • https://github.com/livekit/components-js/issues/894
  • https://github.com/livekit-examples/voice-assistant-frontend/pull/110

ultimately having a PTT component as part of the components lib would be desirable, I think.

lukasIO avatar May 23 '25 06:05 lukasIO

what's the idea behind customisable keyboard shortcuts, have users asked for this? 👀

@lukasIO if this were part of the components lib, it would be a requirement to make the shortcuts user-configurable, IMO. We can't know what keybindings are already being used. As for why I implemented it here, I guess just because even between just a few people who wanted this feature in Meet, we had different ideas on what the command should be. @anunaym14 had specifically asked for PTT bound to a mouse button. For some that may be unexpected (especially main mouse button), others don't have a middle mouse button if using a laptop touchpad for example. I personally wanted to use Spacebar, which aligns with some other video conferencing software.

ultimately having a PTT component as part of the components lib would be desirable, I think.

Absolutely! I know there have been ideas on how to implement it, and there is overlap with the "Agent PTT" feature which @longcw was working on (though different use-cases). I don't think that means we should scrap this work, which adds a feature I have been desperately wanting in Meet, and which we could learn from. In any case, if and when we do implement PTT at the framework level, this code should be simple to strip out, as all the logic is really contained in one component and a hook or two.

rektdeckard avatar May 23 '25 15:05 rektdeckard

@davidzhao Yes, it would be great and extremely helpful if we could have the PTT example for the PTT agent. I'm thinking the best example we can provide for the push-to-talk agent is in the meeting, which already has a room with multiple participants.

Khalid1G avatar Jul 03 '25 10:07 Khalid1G