preevy icon indicating copy to clipboard operation
preevy copied to clipboard

Rename `preevy down` to `preevy rm`

Open royra opened this issue 1 year ago • 3 comments

Per feedback from @Pradumnasaraf , preevy down might seem to stop the services and keep the machine.

For backwards-compat, keep down as an alias

royra avatar Aug 07 '23 07:08 royra

Documenting an internal discussion:

  • If we have an up command, it makes sense that the opposite would be down, just like Docker Compose:
    • Docker Compose's down command stops and removes the containers - this is equivalent to Preevy's down command
    • Docker Compose's rm command removes stopped containers (and ignores running containers) - the suggested rm is not equivalent.
  • Maybe we can alias down to rm, or have a dummy rm command which just outputs did you mean "down"?

royra avatar Aug 08 '23 14:08 royra

Ah, this makes sense.

Maybe we can alias down to rm, or have a dummy rm command which just outputs did you mean "down"?

Like this idea.

Pradumnasaraf avatar Aug 08 '23 15:08 Pradumnasaraf

i am beginner in this filed but i can rename it. so, only tell me, should i rename all the 'preevy down' to 'preevy rm'?

Sumit21kumar avatar Aug 18 '23 05:08 Sumit21kumar