livebook
livebook copied to clipboard
Add autocompletion of bitstring
via. https://github.com/livebook-dev/livebook/issues/1267
It's just copy this: https://github.com/elixir-lang/elixir/commit/f49b3cbec3268a266d995d46fff4775faea5be4a I don't know how. Is there a good idea?
The existing code already has logic for handling struct fields, but it is duplicated now with your changes. You have to merge the Elixir additions in the current code but this is in the correct direction!
The existing code already has logic for handling struct fields, but it is duplicated now with your changes. You have to merge the Elixir additions in the current code but this is in the correct direction!
How can I merge "Elixir additions in the current code"? What does "Elixir additions" means? Thx :)
What I mean is that the Elixir patch you took as inspiration changed existing code. The existing code that it changed already existed in this repo, so you need to change said code accordingly. :)
@ByeongUkChoi can you please rebase? Main now depends on 1.14, so this will be soon good to go!
thank you @ByeongUkChoi! Can you please push some tests? Then this is good to go!