livebook icon indicating copy to clipboard operation
livebook copied to clipboard

Add autocompletion of bitstring

Open ByeongUkChoi opened this issue 1 year ago • 3 comments

via. https://github.com/livebook-dev/livebook/issues/1267

It's just copy this: https://github.com/elixir-lang/elixir/commit/f49b3cbec3268a266d995d46fff4775faea5be4a I don't know how. Is there a good idea?

ByeongUkChoi avatar Jul 21 '22 11:07 ByeongUkChoi

The existing code already has logic for handling struct fields, but it is duplicated now with your changes. You have to merge the Elixir additions in the current code but this is in the correct direction!

josevalim avatar Jul 21 '22 11:07 josevalim

The existing code already has logic for handling struct fields, but it is duplicated now with your changes. You have to merge the Elixir additions in the current code but this is in the correct direction!

How can I merge "Elixir additions in the current code"? What does "Elixir additions" means? Thx :)

ByeongUkChoi avatar Jul 22 '22 16:07 ByeongUkChoi

What I mean is that the Elixir patch you took as inspiration changed existing code. The existing code that it changed already existed in this repo, so you need to change said code accordingly. :)

josevalim avatar Jul 22 '22 16:07 josevalim

@ByeongUkChoi can you please rebase? Main now depends on 1.14, so this will be soon good to go!

josevalim avatar Aug 23 '22 06:08 josevalim

thank you @ByeongUkChoi! Can you please push some tests? Then this is good to go!

josevalim avatar Aug 27 '22 07:08 josevalim