John Rayes

Move a bunch of repeat functions to a trait

6

No need for constantly implementing the same `load()` and `call()` in every action, we have traits for that.

- The Report controller uses the new objects instead of raw SQL queries. Insert reference to Pinocchio saying "I'm a Real Boy now!" - Add a new report type for...

`composer lint-fix` doesn't work on windows commandline

3

https://github.com/SimpleMachines/SMF/blob/b11d8c4178b3d8e18a5243c33174524d216b8e4e/composer.json#L17  same result with the terminal provided by sourcvtrree 

[3.0] Subaction interface

5

### Motivation To cut down on the use of static properties as much as possible and implement well-defined methods for adding sub-actions. The goal here would be to hook into...

### Setup 1. Two users: admin and global moderator 2. The preinstalled board with default permissions ### Recreate 1. Create a membergroup 4. Set that membergroup to deny as board...

loadPermissionsBatch() does not entirely load permission profiles

1

it confused me at first because I left `$profile` `null`,, expeting no data to be loaded. Anyway, here my code ```php $group_data = Group::loadSimple( Group::LOAD_NORMAL | (int) !empty(Config::$modSettings['permission_enable_postgroups']), [Group::ADMIN, Group::MOD]...

> I am no longer able to support or maintain this project - if you would like to take over the project, please drop me a line. HI @iignatov I'd...

Improve performance

2

I have identified three main bottlenecks when profiling the code with xdebug: 1. `array_shift()`: The array of tokens ended up being renumbered on each iteration. So we instead set consumed...

Make the regex for the cycle tag less greed

1

Fix #179 Resubmit #180

### Code to reproduce ```liquid {% cycle 44, "one", "three" %} {% cycle "one", "two", "three" %} {% cycle "one", "two ::,,ree" %} {% cycle "one", "two ::,,ree" %} {%...