NeRO icon indicating copy to clipboard operation
NeRO copied to clipboard

About the rescaling of roughness in Stage 2.

Open K-nowing opened this issue 2 years ago • 2 comments

Thank you for your work!

From the code of stage 2, why do you set the min of roughness 0.04? https://github.com/liuyuan-pal/NeRO/blob/7f3673532113cf40433d4d686c9ac7e8c0f9813f/network/field.py#L919

Is there a physical reason for this, or is it just a hyperparameter?

Thanks!

K-nowing avatar Jan 10 '24 11:01 K-nowing

Hi, this is only a hyperparameter. When I use 0, there may be some numerical issues when computing the BRDF and there are no perfectly smooth objects. Thus, I chose this 0.04 threshold. Thank you!

liuyuan-pal avatar Jan 11 '24 04:01 liuyuan-pal

Thank you!

K-nowing avatar Jan 11 '24 06:01 K-nowing