Nicholas comments

Results 36 comments of


                                            Nicholas

Use @llvm.memcpy.p0.p0.i64 instead of @llvm.memcpy.p0.p0.i32

Thank you! Sorry for my slow response. But I will try to figure out this issue.

Use @llvm.memcpy.p0.p0.i64 instead of @llvm.memcpy.p0.p0.i32

in `LLVMIntrinsicConversions.inc` (which is generated by llvm I guess?) ``` if (auto op = dyn_cast(opInst)) { auto *inst = LLVM::detail::createIntrinsicCall( builder, moduleTranslation, &opInst, llvm::Intrinsic::memcpy,0,{},{0, 1, 2},{3},{StringLiteral("isVolatile")}); (void) inst; moduleTranslation.setAccessGroupsMetadata(op, inst);...

[CIR][LowerToLLVM] Lowered LLVM code for pointer arithmetic should have inbounds

Alright, I'll work on `LowerToLLVM` to address this issue. In fact, I'm not entirely sure when the `inbounds` attribute should be added. I examined the code in `Value *emitPointerArithmetic` from...

[CIR][LowerToLLVM] Lowered LLVM code for pointer arithmetic should have inbounds

Thank you. Let me check it.

[CIR][LowerToLLVM] Lowered LLVM code for pointer arithmetic should have inbounds

@Lancern Hi, I have update the code and could you please review it?

[CIR][LowerToLLVM] Lowered LLVM code for pointer arithmetic should have inbounds

Hi, @seven-mile , I have updated the commit, please review it. Thanks!

Most of elementwise builtins are not supported

I will work on it.

CIR generated LLVM code for pointer arithmetic misses inbounds

I can work on it to learn ClangIR.

CIR generated LLVM code for pointer arithmetic misses inbounds

Thank you! I know that ClangIR is good for analysis and can make c++ safer. Apart from this, can we do something else?

CIR generated LLVM code for pointer arithmetic misses inbounds

Interesting topics. I love this!