Mingliang Liu
Mingliang Liu
As discussions in #23 go well, I think this issue is of good shape to do. Would you like to work on this @yilihong ? Thanks.
@yilihong No hurry. This is a non-profit program anyway. I appreciate your contribution very much. I think the basic idea of looping over the htmls should work just fine. The...
@mtfelisb and @reswqa mind taking a look? Thanks!
@reswqa @MartijnVisser Could you help review? Thanks
I think this PR is not blocked by [FLINK-27331](https://issues.apache.org/jira/browse/FLINK-27331) or [FLINK-17224](https://issues.apache.org/jira/browse/FLINK-17224), though [FLINK-17224](https://issues.apache.org/jira/browse/FLINK-17224) blocks [FLINK-27331](https://issues.apache.org/jira/browse/FLINK-27331). This PR is for TIMESTAMP data type and the two other JIRAs are for TIME.
@reta @snuyanzin Could you take a look? Thank you!
@snuyanzin could you help review on this? Andriy and I don't have write permissions. Thank you!
Thank you @snuyanzin for taking another look. I see a lot of errors like this, and not sure if this is causing the compile & test to timeout > Warning:...
``` Error: Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.8.0:testCompile (default-testCompile) on project flink-connector-elasticsearch-base: Compilation failure Error: /home/runner/work/flink-connector-elasticsearch/flink-connector-elasticsearch/flink-connector-elasticsearch-base/src/test/java/org/apache/flink/connector/elasticsearch/sink/ElasticsearchWriterITCase.java:[485,20] org.apache.flink.connector.elasticsearch.sink.ElasticsearchWriterITCase.TestMailbox is not abstract and does not override abstract method shouldInterrupt() in org.apache.flink.api.common.operators.MailboxExecutor ``` We...
Rebasing from `main` branch.