Kun Liu

Results 92 comments of Kun Liu

We can add `checkstyle` plugin in `pom.xml` to check code style

Using the google-java-format plugin can help us to format code when compiling the code. You can use `mvn compile` to format your code, before submitting it. We can add `checkstyle`...

@jt2594838 这个问题导致了什么bug没有?

please ensure that the interface is not redundant #524

`addNameSpaceToOverflowList`是必须是每次overflow操作的时候都应该被调用,并且把这次overflow操作对应的FileNodePath记录下来(记录到`overflowNameSpaceSet`)。所以`overflowNameSpaceSet`记录的是当前内存中的overflow内容,当需要把当前内存中的overflow数据写入磁盘之前需要把`overflowNameSpaceSet`中的内容添加到所有已经写入到磁盘的内容中去。并且这个过程要分解成两个阶段: 1.第一个阶段是把`overflowNameSpaceSet`的内容添加到backUpOverflowNameSpaceSet中(flush数据前) 2.第二个阶段是把`backUpOverflowNameSpaceSet`的内容写入到磁盘中。(flush数据以后) 原本实现方式导致的问题是:某个FileNode对应的overflow并没有flush,但是其对应的FileNodePath已经被备份到磁盘中。恢复的时候会造成某些没有overflow数据的FileNode被标记为有overflow数据。 改进方法: `overflowBackUpAction`调用需要传入参数,其中参数为某个FileNodePath,这样,每次只把对应需要flush overflow数据的FileNode添加到backupset中。

which branch? Does the master branch have such problem? @Beyyes

> Hi @liukun4515. Could you please check if this bug has been fixed. we can close it, the issue has been resolved. Thanks @HaoYang670

> I wonder if we should claim this ticket is complete? I wonder if there is anything else this ticket is tracking I will check above unclosed issue in this...

Do we have any method to convert or cast the integer type/integer expr with the timeunit to the interval? @waitingkuo @alamb I want to implement a app or function like...