Kun Liu

Results 92 comments of Kun Liu

> > @alamb what should I do with it? Should I Introduce new methods for Dialect to allow these operators with Generic dialect? > > What about allowing `BinaryOperator::PGBitwiseShiftRight` in...

this feature can be used to do some optimization in plan optimizer or expression folding

> In my mind, if we we always ran 'constant folding' on an `Expr` then checking for a constant should be a matter of calling `matches!(expr, Expr::Literal)` > > In...

> @alamb @liukun4515 I updated the release checklist to include a few issues that are still open. I think it may be better to delay the release by a few...

Optimize the decimal value from arrow-rs https://github.com/apache/arrow-rs/issues/2313

> Here is a self contained reproducer for anyone following along: > > ```sql > ❯ create table foo as select column1 as d from (values (1), (2)); > +---+...

> +1 for optimization rules to perform type coercion in the logical plan. I am running into some issues around this myself and am seeing quite a lot of inconsistencies...

> > The cast is added in the creation of physical expr/physical plan. > > Yes I agree > > It sounds like you are proposing moving the coercion to...