fastest icon indicating copy to clipboard operation
fastest copied to clipboard

handle mysql master / slave connection

Open jdeniau opened this issue 5 years ago • 3 comments

Actually, the $dbName is computed either from $params['dbname'] on $params['master']['dbname'] and override only the dbname parameter (not the master one) and there is no slave management except for sqlite.

This PR compute the dbname from the mysql connection and replace both dbname, master's dbname and all slaves dbname.

I test if the driver is pdo_mysql, but it might be the default case, what do you think ?

jdeniau avatar Oct 07 '20 09:10 jdeniau

I didn't had the chance to take a look at this. Would you mind to rebase this? Moreoever I can't guarantee I'll have much free time to review this, but sooner or later I'll do. Thanks.

DonCallisto avatar Oct 09 '20 12:10 DonCallisto

@DonCallisto rebase done.

Take the time you need for the review, I'm using my patched version for the moment.

Thanks for maintaining this library !

jdeniau avatar Oct 09 '20 12:10 jdeniau

Doing my best with my little free time. Thank you for contributing.

DonCallisto avatar Oct 09 '20 12:10 DonCallisto