ExcelBundle icon indicating copy to clipboard operation
ExcelBundle copied to clipboard

Update AppKernel.php

Open Aliance opened this issue 7 years ago • 9 comments

Without namespace IDE throws an error of duplicated class: 2017-04-21 12 15 21

Aliance avatar Apr 21 '17 09:04 Aliance

you need to update the testsuite to make it use the namespaced kernel though

stof avatar Apr 21 '17 09:04 stof

My local tests passed:

~/www/Aliance/ExcelBundle $ ./bin/phpunit 
PHPUnit 4.8.35 by Sebastian Bergmann and contributors.

.........

Time: 237 ms, Memory: 17.75MB

OK (9 tests, 19 assertions)

Test fails at travis in PHP 5.3 🤔 , seems to be the same behavior in master?

Aliance avatar Apr 21 '17 10:04 Aliance

@liuggio review please

Aliance avatar Apr 21 '17 13:04 Aliance

@Aliance thanks a lot!

the problem is on “[“ on <5.4 PHP version :( I'll look into that ASAP...

liuggio avatar Apr 21 '17 18:04 liuggio

@liuggio did you have enough time to watch out the problem?

Aliance avatar Apr 29 '17 07:04 Aliance

@liuggio hello. Sorry for being annoying but may be merge this pr?

Aliance avatar May 08 '17 09:05 Aliance

Sorry for the delay but this needs a major version, and this is not a killer feature :(

liuggio avatar May 08 '17 13:05 liuggio

@liuggio any news?

Aliance avatar Oct 01 '17 21:10 Aliance

@liuggio why does it need a major version ? This changes a class in the testsuite fixtures. This class is not autoloadable when using the bundle in projects.

stof avatar Oct 02 '17 08:10 stof