Guangdong Liu comments

Results 302 comments of


                                            Guangdong Liu

[Feature][Connector-V2] jdbc connector supports Kingbase database

> LGTM Please screenshot the test results. PTAL @ic4y

core[patch]: Fix JsonOutputParser returns empty json when text ends with "\".

@eyurtsev This is a bug, please take a look, thanks.

core[patch]: Fix JsonOutputParser returns empty json when text ends with "\".

@eyurtsev PTAL

Use spotless plugin to format the code to ensure that the format of the submitted code is uniform

@KomachiSion Can we format code with spotless?

Use spotless plugin to format the code to ensure that the format of the submitted code is uniform

> No, maven plugin reformat code will cause many invalid the commits in PR. We prefer use codeStyle to do it when developer developing. emm.. you're right. This is a...

Use spotless plugin to format the code to ensure that the format of the submitted code is uniform

Thank you for your reply. Both points you mentioned can be satisfied.I can submit a pr to fix it.

Use spotless plugin to format the code to ensure that the format of the submitted code is uniform

https://nightlies.apache.org/flink/flink-docs-stable/docs/flinkdev/ide_setup/#intellij-idea This is the formatting of the code of Apache Flink.We can refer to it.

Use spotless plugin to format the code to ensure that the format of the submitted code is uniform

> The document in nacos also included, both document and source codes. > > From your PR, I can't get the key point. Did you means that the spotless plugin...

Use spotless plugin to format the code to ensure that the format of the submitted code is uniform

https://github.com/apache/doris/pull/25033 My pr in apache doris, but I removed the checkstyle check. I can't resolve the conflict between these two plugins, therefore, I chose to use spotless to cover the...

Wikipedia Tool not working as expected in Agents: Google API

Do not call `agent.invoke` directly but use ```agent_executor = AgentExecutor(agent=agent, tools=tools) result = agent_executor.invoke({"input": "some question?"})```