cloud_bbb icon indicating copy to clipboard operation
cloud_bbb copied to clipboard

Only one Format is handled

Open sushifrick opened this issue 4 years ago • 4 comments

Hi All,

we are using a separate post processing script to generate downloadable recordings as mp4 files. We do use the scripts from here:

https://github.com/tilmanmoser/bbb-video-download

Due to this process there are more than one recordings possible for a meeting. In Greenlight this shows up in the "Formats" column as "Download" and "Presentation". Unfortuanetely once the post processing is done, the nextcloud integration only shows the link to the generated mp4 file, not the web presentation with the chat and slides.

I looked around the code and it looks like you just use the first response as a recording although it is an array here:

https://github.com/sualko/cloud_bbb/blob/2a49538d418393da5f5483d7d98905914a18e0aa/lib/BigBlueButton/API.php#L176

Is it possible to use the whole array and add each recording to the list? If not could you filter to only use the URL where the $record->getPlaybackType() is "presentation"? I guess this is the default entry for the recordings player of BBB.

Kind regards, keep up the good work Sascha

sushifrick avatar Feb 25 '21 15:02 sushifrick

Thanks for your bug report. I think the correct way of handling this, would be to show all records, but unfortunately I'm currently busy. If you have time, I would appreciate a pull request, otherwise you probably have to wait some time. Sorry for the inconvenience anyway.

sualko avatar Mar 09 '21 08:03 sualko

I was looking into your issue and the referenced line is correct. The problem is that one record can have multiple playback types and our php client is just returning one. I opened an issue: https://github.com/littleredbutton/bigbluebutton-api-php/issues/66

sualko avatar Apr 18 '21 17:04 sualko

I was looking into your issue and the referenced line is correct. The problem is that one record can have multiple playback types and our php client is just returning one. I opened an issue: littleredbutton/bigbluebutton-api-php#66

I see API merged 1 year ago the fix. Can you please update your code?

amg-web avatar Nov 02 '23 07:11 amg-web