font-awesome-sass-rails icon indicating copy to clipboard operation
font-awesome-sass-rails copied to clipboard

Consider deprecating this gem in favor of font-awesome-rails

Open rmm5t opened this issue 12 years ago • 3 comments

In an effort to avoid community confusion, I'd like to propose deprecating this gem in favor of bokmann/font-awesome-rails.

Reasons: The font-awesome-rails gem...

  • tracks Font-Awesome core very closely.
  • has a test suite
  • works with Rails 3.2 and Rails 4
  • works when fonts are stored on a CDN (like CloudFront)
  • doesn't require sass or less, but
  • still works with sass imports
  • includes view helpers for rendering different kinds of icon formats

I think this is all especially important, because Font-Awesome core dropped sass support in v3.1 which will make it much harder to keep this gem up to date. Consolidating everyone's efforts into one canonical rails engine is also a win.

font-awesome-rails is basically a drop-in replacement for font-awesome-sass-rails, but with some extras.

If you're open to this, I suggest:

  1. Clearing out the repository, but
  2. Leave just a README with a pointer and explaination that font-awesome-rails should be used instead.

(I'm happy to submit a pull-request with this deprecation to save you time.)

Thoughts?

Update: Font-Awesome core re-introduce sass support in v3.2

rmm5t avatar Jun 02 '13 16:06 rmm5t

That would be quite reasonable in my opinion.

paav-o avatar Aug 09 '13 22:08 paav-o

@paav-o Thanks for chiming in. I converted this into a pull-request in case it's seen as a benefit. Either way.

rmm5t avatar Aug 09 '13 23:08 rmm5t

That gem just bundles the compiled CSS, not the Sass version, which means it doesn't provide mixins. It looks like the version of the Sass files currently in this repo (v3.0) basically does the same thing, but requires Sass, so I agree that font-awesome-rails is a good replacement for what's here now. However, the most recent version of Font Awesome (v3.2) has all-new Sass support (it was removed for v3.1 and rebuilt in v3.2) which does provide mixins rather than force you to use icon-* classes in your DOM.

I'd rather see this gem upgraded to that version of FA (and if I have the time, I'll pull request it).

Peeja avatar Oct 07 '13 13:10 Peeja