force-https icon indicating copy to clipboard operation
force-https copied to clipboard

Backwards compatibility

Open ghostal opened this issue 6 years ago • 1 comments

Thanks for your work on this plugin!

With the most recent update, the short syntax for PHP arrays breaks PHP 5 installs. These changes fix it again.

Dropping support for PHP 5 at this stage is pretty reasonable, but I'd suggest bumping the major version if the plan is to no longer support it, as it's a breaking change for sites still running on PHP 5.

ghostal avatar May 18 '18 09:05 ghostal

Thanks for the feedback Alex, however, our plugins have never claimed to support anything other than PHP version 7.0 (any other compatibility is simply coincidental).

We follow WordPress version/branches so don't have a good way to merge pull requests yet.

However we will review this for next version.

jessuppi avatar May 20 '18 00:05 jessuppi