`cleanup-chaos-resources` not executed

[smitthakkar96]

What happened:

If a fault fails (see the screenshot), the cleanup step is not executed

When the UI shows that the cleanup wasn't done, it creates ambiguity among our users if the fault injection has actually stopped and required resources that were to be removed were actually deleted or not.

What you expected to happen:

The cleanup step should execute irrespective of the fault status to ensure removal of any lingering resources.

Where can this issue be corrected? (optional)

Consider using Exit Handlers in Argo Workflows for such cleanup use-cases

[SarthakJain26]

@smitthakkar96 Ideally the cleanup step should work even if the fault fails.Sometimes the resources gets cleaned up but the status is not reflected in the UI. Can you try to reproduce this and share the subscriber logs. cc: @ispeakc0de

[smitthakkar96]

@SarthakJain26 that wouldn't be the case if any step in workflow exits with a non-zero status code. I think it's default behaviour of Argo Workflows. Let me try to reproduce it and share you the logs.