litmus icon indicating copy to clipboard operation
litmus copied to clipboard

chore: declared variable is not used

Open namkyu1999 opened this issue 1 year ago • 2 comments

This result of append is never used. @Saranya-jena added this variable. Can you take a look at this code?

https://github.com/litmuschaos/litmus/blob/399af62ca877c265160ea9edc6a2b8ee1b7f5f9d/chaoscenter/graphql/server/pkg/chaos_experiment/ops/service.go#L724-L727

namkyu1999 avatar Jan 18 '24 07:01 namkyu1999

Hi @namkyu1999, The result of the append operation is never used, might be a slight possibility that the code is incomplete

nanu1605 avatar Jan 25 '24 08:01 nanu1605

Hey @namkyu1999 I think that the code is incomplete and this code should be like that code.

Could you please assign this issue to me, So I can update the changes?

/assign

prashantrewar avatar Feb 08 '24 12:02 prashantrewar

I want to work on this.

I think we have to return the probes in the UpdateRuntimeCronWorkflowConfiguration func as well. @Saranya-jena, need your view before proceeding.

kanhaiya04 avatar Feb 19 '24 17:02 kanhaiya04

Going on the first come basis, @prashantrewar are you still interested in working on this issue?

Saranya-jena avatar Feb 27 '24 05:02 Saranya-jena

Hey @Saranya-jena and @kanhaiya04, I think the issue is resolved in this PR.

prashantrewar avatar Mar 14 '24 17:03 prashantrewar

@prashantrewar this issue is not resolved, anyone who wants to work on this issue, please raise a pr 😄

namkyu1999 avatar Mar 15 '24 00:03 namkyu1999

@namkyu1999 @Saranya-jena If possible, I can take this up!

rootxrishabh avatar Mar 15 '24 21:03 rootxrishabh

Hey @prashantrewar , let me know if you are interested in working on this issue, if not I will assign this issue to @rootxrishabh

namkyu1999 avatar Mar 16 '24 03:03 namkyu1999

can you share the updates @rootxrishabh ?

namkyu1999 avatar Apr 03 '24 02:04 namkyu1999

@namkyu1999 I'm unable to take on this task at the moment. My apologies. @MichaelMorrisEst has already made a PR addressing the issue. Right?

rootxrishabh avatar Apr 03 '24 05:04 rootxrishabh

np @rootxrishabh 😄

namkyu1999 avatar Apr 03 '24 06:04 namkyu1999