chaos-operator icon indicating copy to clipboard operation
chaos-operator copied to clipboard

Wrong default value of probe success percentage for experiments with `Awaited` status. Value is 100 instead of 0

Open ishangupta-ds opened this issue 3 years ago • 2 comments

BUG REPORT

What happened:

While running a chaos predefined workflow from litmus portal UI for sock-shop application, I deleted all the chaos engines and all workflows from the litmus namespace, resulting in the workflow failing, but somehow I got a resilience score as a non zero value, upon debugging it seems the experiment with awaited status had a probe success percentage of 100

What you expected to happen:

Ideally, as per the docs probe success percentage of awaited experiment result should have been 0 unless a concrete experiment verdict is available i.e either pass or fail.

How to reproduce it (as minimally and precisely as possible):

Run a workflow from the litmus portal and delete the chaos engines and argo workflow created on the agent while it runs after the experiment job is created.

Anything else we need to know?:

API version and code reference: https://github.com/litmuschaos/litmus/blob/master/litmus-portal/cluster-agents/subscriber/pkg/cluster/events/util.go

Here is the screenshot of the debugging.

Screenshot 2021-03-16 at 1 06 49 PM

ishangupta-ds avatar Mar 16 '21 08:03 ishangupta-ds

https://github.com/litmuschaos/litmus/pull/2558 This PR adds a check on the portal's frontend to filter the value but it will be helpful if it's handled at the infra level too.

ishangupta-ds avatar Mar 16 '21 08:03 ishangupta-ds

Another bug due to this issue:

Screenshot 2021-03-30 at 12 56 59 PM

ishangupta-ds avatar Mar 30 '21 07:03 ishangupta-ds

This has already been fixed, closing the issue. Thanks for raising the issue!

neelanjan00 avatar Mar 14 '24 05:03 neelanjan00