rauth icon indicating copy to clipboard operation
rauth copied to clipboard

Upload file bug with oauth signing was fixed

Open nickspring opened this issue 11 years ago • 10 comments

It was a mistake to set content-type = application/x-www-form-urlencoded by default, requests lib setup it dynamically if we have non-empty parameter "files".

Original version didn't work with images (files) upload for example in Etsy API see https://www.etsy.com/developers/documentation/getting_started/images

nickspring avatar Nov 23 '14 22:11 nickspring

This isn't passing tests:

rauth/session.py:152:80: E501 line too long (86 > 79 characters)

maxcountryman avatar Nov 24 '14 21:11 maxcountryman

Still not passing due to:

rauth/session.py:153:13: E125 continuation line with same indent as next logical line

Also Github does not send notifications when PRs are updated, so please make a comment when this is ready to merge so I get an alert.

maxcountryman avatar Dec 20 '14 17:12 maxcountryman

I've just changed format and push changes to repository. So please check it.

nickspring avatar Dec 20 '14 19:12 nickspring

Still failing:

rauth/session.py:153:9: E122 continuation line missing indentation or outdented

You may want to run tests locally via tox or some other runner. Also you can check TravisCI for build failures.

maxcountryman avatar Dec 20 '14 19:12 maxcountryman

I don't know what to do, It works for me.

nickspring avatar Dec 20 '14 20:12 nickspring

Are you running the tests with tox?

maxcountryman avatar Dec 20 '14 20:12 maxcountryman

I don't use tox.

nickspring avatar Dec 20 '14 20:12 nickspring

How are you running the tests? It seems like it's not compatible with the Travis runner.

maxcountryman avatar Dec 20 '14 20:12 maxcountryman

I'm not running any tests. I fixed only one line. It works.

nickspring avatar Dec 20 '14 20:12 nickspring

It looks like the tests still aren't passing on Travis. More formatting errors.

maxcountryman avatar Dec 20 '14 20:12 maxcountryman