lsquic icon indicating copy to clipboard operation
lsquic copied to clipboard

Add es_enable_webtransport

Open ghost opened this issue 3 years ago • 5 comments

The first step to support WebTransport is for the server/client to send the setting SETTINGS_ENABLE_WEBTRANSPORT.

This support can be exposed as an Engine Setting, like the two other settings are.

Then in maybe_send_settings in lsquic_full_conn.c this should be read and appended to the outgoing SETTINGS frame.

Does this sound like a reasonable first step? If we can manage this, then lsquic will at least be able to receive and establish a WebTransport session (but more work is need to establish proper WebTransport streams under this session).

I can probably PR this if it sounds reasonable.

ghost avatar Jun 14 '22 06:06 ghost

Sounds great! When will it be done in Lsquic release?

zhenzhu478 avatar Jun 20 '22 03:06 zhenzhu478

Hi

The first step to support WebTransport is for the server/client to send the setting SETTINGS_ENABLE_WEBTRANSPORT.

This support can be exposed as an Engine Setting, like the two other settings are.

Then in maybe_send_settings in lsquic_full_conn.c this should be read and appended to the outgoing SETTINGS frame.

Does this sound like a reasonable first step? If we can manage this, then lsquic will at least be able to receive and establish a WebTransport session (but more work is need to establish proper WebTransport streams under this session).

I can probably PR this if it sounds reasonable.

Hi Alex Any update about this PR? Really looking forward to it.

zhenzhu478 avatar Jun 23 '22 12:06 zhenzhu478

Since it is a big change, we can create a branch for webtransport, and accept pull requests there.

litespeedtech avatar Jun 23 '22 13:06 litespeedtech

Since it is a big change, we can create a branch for webtransport, and accept pull requests there.

Thanks for your reply, and when should this PR be done?

zhenzhu478 avatar Jun 28 '22 08:06 zhenzhu478

It is up to the person who submits the pull request.

litespeedtech avatar Jun 28 '22 13:06 litespeedtech