lscache_wp Minification - whitelist comments

Mar 01 '24 22:03 Tymotey

@lslisa will need to review wording and document new functionality.

Mar 06 '24 19:03 tynanbe

I feel like there should be an option in this setting that will allow you to keep all comments. It surprised me to learn that comments are just discarded. If I were using HTML minification on my site, I would absolutely want comments to be preserved. Can we support a wildcard in this setting? Or a simple checkbox for "Keep all" ?

(If necessary @Tymotey, you can reference the UCSS Selector Allowlist setting to see how we implement wildcard support.)

Mar 11 '24 14:03 lslisa

@lslisa for now we should keep the changes just to keep comments that are in the option list

Mar 11 '24 18:03 Tymotey

Good job!

Apr 19 '24 20:04 hi-hai

thank you

Apr 20 '24 08:04 timotei-litespeed

I feel like there should be an option in this setting that will allow you to keep all comments. It surprised me to learn that comments are just discarded. If I were using HTML minification on my site, I would absolutely want comments to be preserved. Can we support a wildcard in this setting? Or a simple checkbox for "Keep all" ?

All this time later, as I am writing the documentation, I am realizing that by "comments" you are talking about HTML comments NOT the comments that people leave on blog posts 🤦🏻‍♀️

This setting makes so much more sense to me now. Discarding HTML comments makes so much more sense than discarding blog comments. You can disregard my suggestion that we have a "Keep all" checkbox.

Jul 18 '24 18:07 lslisa

@lslisa ok :)

Jul 18 '24 18:07 timotei-litespeed