ls-qpack

ls-qpack copied to clipboard

In the function `header_out_write_value()`, the counter `qpd_bytes_out` is updated after `dhi_process_header()` is called, [instead of before](https://github.com/litespeedtech/ls-qpack/blob/705020b64181e0f38f871af0bfa2d221726c1156/lsqpack.c#L3265L3267): ```c r = dec->qpd_dh_if->dhi_process_header(read_ctx->hbrc_hblock, xhdr); if (r == 0) dec->qpd_bytes_out += xhdr->name_len + xhdr->val_len;...

dtikhonov

https://github.com/litespeedtech/ls-qpack/issues/54

bkmgit

bkmgit

Build Warnings Related to Spectre Mitigation

1

With the latest release, most build warnings went away, except for the following: https://github.com/nibanks/msh3/actions/runs/3868034900/jobs/6593213121#step:7:118 ``` D:\a\msh3\msh3\ls-qpack\deps\xxhash\xxhash.c(461): warning C5045: Compiler will insert Spectre mitigation for memory load if /Qspectre switch specified...

nibanks

Make fallthroughs explicit in lsqpack.c

15

Using `__attribute__((fallthrough));` informs the compiler, in a way it understands, that the fallthrough is explicit and wanted. This allows for the enablement of `-Wimplicit-fallthrough`, which throws warnings/errors for implicit fallthroughs,...

r-barnes

Just need a small patch. ```diff diff --git a/CMakeLists.txt b/CMakeLists.txt index 413b4579..f9f1371d 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -42,14 +42,14 @@ else() set(LSQPACK_DEPENDS "libxxhash") endif() -if(WIN32) +if(MSVC OR MINGW OR...

star-hengxing