lite-xl-plugin-manager icon indicating copy to clipboard operation
lite-xl-plugin-manager copied to clipboard

Version comparison might not be working correctly

Open Guldoman opened this issue 1 year ago • 3 comments

For example here the explicit repo contains the plugin at version 0.1.11, while our main repo contains 0.1.2, but lpm seems to consider 0.1.2 as newer than 0.1.11:

$ lpm run --ephemeral https://github.com/drmargarido/lite-xl-plugins:master todotreeview
warning: your explicitly specified repository https://github.com/drmargarido/lite-xl-plugins:master has a version of todotreeview lower than that in https://github.com/lite-xl/lite-xl-plugins.git:master (0.1.11 vs. 0.1.2; in order to use the one in your specified repo, please specify todotreeview:0.1.11

Guldoman avatar Oct 01 '24 17:10 Guldoman

I don't get this error on master. Do you still get it?

adamharrison avatar Oct 14 '24 00:10 adamharrison

Nop this is still happening. The reason you're not getting the warning is because the change was merged, so both repos have the same todotreeview version. Manually editing the saved "main" repo to have the old version 0.1.2, will result in the warning.

Guldoman avatar Oct 15 '24 05:10 Guldoman

Ah. Right. We don't actually check the version ordinally, only that it's different. Added the check.

d0b6849

adamharrison avatar Jan 11 '25 20:01 adamharrison

If this is still a problem, please reopen.

adamharrison avatar Jun 08 '25 03:06 adamharrison