lit icon indicating copy to clipboard operation
lit copied to clipboard

[labs/router] Extend lit-router to support hash-based routing

Open maischus opened this issue 1 year ago • 3 comments

lit-router currently only uses the pathname to perform the routing. This change extends the routing to search and hash part of an URL.

This should fix lit/lit#3517 and allow urlpattern-polyfill to work correctly (kenchris/urlpattern-polyfill#129) for hash-based routing.

@justinfagnani What are your thoughts on this approach? tailGroup has not been adapted yet. I would like to wait for your thoughts before continuing.

maischus avatar Jun 26 '24 18:06 maischus

⚠️ No Changeset found

Latest commit: 4cb67c7253d2d04a61514fb5f25e25fe54525736

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

changeset-bot[bot] avatar Jun 26 '24 18:06 changeset-bot[bot]

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

google-cla[bot] avatar Jun 26 '24 18:06 google-cla[bot]

Hey, I'd like to help with this. If the author isn't active, I'd be happy to continue implement the feature

xseman avatar Nov 04 '25 14:11 xseman