lit-element-starter-ts icon indicating copy to clipboard operation
lit-element-starter-ts copied to clipboard

fix npm run lint on Windows

Open johnstonmatt opened this issue 5 years ago • 9 comments

npm run lint fails because eslint does not like the 's wrapping its target path. Removing the single quotes fixes npm run lint

johnstonmatt avatar Jun 10 '20 08:06 johnstonmatt

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

googlebot avatar Jun 10 '20 08:06 googlebot

@googlebot I signed it!

johnstonmatt avatar Jun 10 '20 08:06 johnstonmatt

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

googlebot avatar Jun 10 '20 08:06 googlebot

Why doesn't work for you with the '? I use it in a lot of projects and works well.

abdonrd avatar Jun 10 '20 08:06 abdonrd

It may be an environment thing, certainly running npm run lint fails for this reason on my machine

johnstonmatt avatar Jun 10 '20 08:06 johnstonmatt

I've just confirmed this is only an issue on my Windows rig, on my Mac all is well

johnstonmatt avatar Jun 10 '20 08:06 johnstonmatt

The fix in this PR is compatible with both of my machines, but I'll leave this to your discretion

johnstonmatt avatar Jun 10 '20 08:06 johnstonmatt

Got it, you are right! Windows issue!

abdonrd avatar Jun 10 '20 09:06 abdonrd